Repository navigation
fix: compute texture dimensions per-bin in multi-pack mode - #185
Open
milescremen-vgw wants to merge 1 commit into
Open
milescremen-vgw wants to merge 1 commit into
milescremen-vgw wants to merge 1 commit into
Conversation
milescremen-vgw
marked this pull request as draft
August 12, 2026 01:33
milescremen-vgw
force-pushed
the
fix/texture-packer-multipack-per-bin-dimensions
branch
3 times, most recently
from
August 12, 2026 02:17
84b356f to
7b659f8
Compare
Previously, fitTextureToPacker was called once on the entire packer, using only the first bin's rect layout to determine width/height. In multi-pack scenarios where textures overflow into multiple bins, each bin can have different dimensions. This caused subsequent bins to use incorrect (oversized) sheet dimensions from the first bin. Move the fitTextureToPacker call into the per-bin loop within both createTextures and createJsons, so each bin gets its own correctly computed width and height.
milescremen-vgw
force-pushed
the
fix/texture-packer-multipack-per-bin-dimensions
branch
from
August 12, 2026 02:22
7b659f8 to
825b545
Compare
milescremen-vgw
marked this pull request as ready for review
August 12, 2026 02:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #171
Previously, fitTextureToPacker was called once on the entire packer, using only the first bin's rect layout to determine width/height. In multi-pack scenarios where textures overflow into multiple bins, each bin can have different dimensions. This caused subsequent bins to use incorrect (oversized) sheet dimensions from the first bin.
Move the fitTextureToPacker call into the per-bin loop within both createTextures and createJsons, so each bin gets its own correctly computed width and height.